Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rubygem-http to 5.2.0-1 #11167

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from
Open

Bump rubygem-http to 5.2.0-1 #11167

wants to merge 1 commit into from

Conversation

ochnerd
Copy link

@ochnerd ochnerd commented Aug 23, 2024

Needs:
base64 PR #11164 has no dependencies
llhttp-ffi PR #11165 has dependencies which can be resolved
http-form_data PR #11166 has no dependencies

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@ochnerd ochnerd force-pushed the rpm/develop_bump-http branch from fb1199e to 4afa066 Compare August 23, 2024 09:47
ekohl
ekohl requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefer base64 from default gems on Ruby < 3.3, just like we did in #10490.

@ochnerd
Copy link
Author

ochnerd commented Aug 26, 2024

Oh ok, i will add the changes and use the default gems. But #11166 and #11165 need to be resolved first because they are needed.

@ochnerd ochnerd force-pushed the rpm/develop_bump-http branch from 4afa066 to dd141ba Compare August 26, 2024 05:45
@ochnerd ochnerd requested a review from ekohl August 26, 2024 12:03
@ekohl
Copy link
Member

ekohl commented Aug 26, 2024

Oh ok, i will add the changes and use the default gems. But #11166 and #11165 need to be resolved first because they are needed.

If they aren't build dependencies (and in this case I think they aren't) you can include them in the same PR).

@ochnerd
Copy link
Author

ochnerd commented Aug 26, 2024

Oh ok, i will add the changes and use the default gems. But #11166 and #11165 need to be resolved first because they are needed.

If they aren't build dependencies (and in this case I think they aren't) you can include them in the same PR).

Hm in this original PR #11157 the Repoclosure failed because of missing dependencies.
Because of this I created a PR for each RPM.

So now I'm a little confused.

@ochnerd
Copy link
Author

ochnerd commented Sep 3, 2024

@ekohl , can really include them in the same PR if it failed like in #11157 (comment) mentioned?

@ekohl
Copy link
Member

ekohl commented Sep 3, 2024

I think you may be right that we need all dependencies.

For some reason, CI didn't run at all on this PR so it looks like nothing is wrong.

@ochnerd ochnerd mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl Awaiting requested review from ekohl

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
RPM Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ochnerd @theforeman-bot @ekohl